Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2638413005: [GeometryInterface] add fromQuad function in DOMQuad. (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, Hwanseung Lee(hs1217.lee)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] add fromQuad function in DOMQuad. The fromQuad(other) static method on DOMQuad must create a DOMQuad from the DOMQuadInit dictionary other. To create a DOMQuad from a DOMQuadInit dictionary other, follow these steps: 1.Let point 1 be the result of invoking create a DOMPoint from the dictionary p1 dictionary member of other, if it exists. 2.Let point 2 be the result of invoking create a DOMPoint from the dictionary p2 dictionary member of other, if it exists. 3.Let point 3 be the result of invoking create a DOMPoint from the dictionary p3 dictionary member of other, if it exists. 4.Let point 4 be the result of invoking create a DOMPoint from the dictionary p4 dictionary member of other, if it exists. 5.Return a new DOMQuad with p1 set to point 1, p2 set to point 2, p3 set to point 3 and p4 set to point 4. spec list: https://drafts.fxtf.org/geometry/#dom-domquad-fromquad BUG=678237 Review-Url: https://codereview.chromium.org/2638413005 Cr-Commit-Position: refs/heads/master@{#447383} Committed: https://chromium.googlesource.com/chromium/src/+/644c88d494c4045bb2df9d77a01bb1e6e3e3b370

Patch Set 1 #

Patch Set 2 : [WIP] formQuad #

Patch Set 3 : [WIP] formQuad #

Patch Set 4 : [WIP] formQuad #

Patch Set 5 : [WIP] formQuad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html View 1 2 3 4 2 chunks +29 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.cpp View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMQuad.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (24 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you.
3 years, 11 months ago (2017-01-21 14:23:15 UTC) #17
dominicc (has gone to gerrit)
lgtm
3 years, 10 months ago (2017-01-31 22:40:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638413005/80001
3 years, 10 months ago (2017-01-31 22:40:50 UTC) #24
Hwanseung Lee
On 2017/01/31 22:40:03, dominicc (slow until 2.6) wrote: > lgtm Thanks, I came in BlinkOn7. ...
3 years, 10 months ago (2017-02-01 00:37:38 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 00:41:43 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/644c88d494c4045bb2df9d77a01b...

Powered by Google App Engine
This is Rietveld 408576698