Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2638413002:
[Blink>Media] Mark MediaSession status as "test" in RuntimeEnabledFeatures (Closed)
|
Created:
3 years, 11 months ago by Zhiqiang Zhang (Slow) Modified:
3 years, 11 months ago CC:
blink-reviews, chromium-reviews, kinuko+watch, mlamouri (slow - plz ping) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures
As Media Session API is enabled by default on Android, and
disabled for other platforms, we need to mark it as "test" so it
won't be enabled when "experimental web platform features" is
enabled, while it's enabled in tests.
BUG=679303
Review-Url: https://codereview.chromium.org/2638413002
Cr-Commit-Position: refs/heads/master@{#444781}
Committed: https://chromium.googlesource.com/chromium/src/+/054f78b8996675673b5dab034b5b7f2698e4e9d5
Patch Set 1 #Patch Set 2 : status=test #Patch Set 3 : . #Messages
Total messages: 24 (19 generated)
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, there is no need to keep it experimental in RuntimeEnabledFeatures. This CL removes the status. BUG=679303 ========== to ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, and disabled for othe rplatforms, we need to mark it as "test" so it won't be enabled when "experimental web platform features" is enabled, while it's enabled in tests. BUG=679303 ==========
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
zqzhang@chromium.org changed reviewers: + jochen@chromium.org
+jochen CC:mlamouri
mlamouri@chromium.org changed reviewers: + mlamouri@chromium.org
There is a typo in the description: s/othe rplatforms/other platforms/ lgtm otherwise :)
Description was changed from ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, and disabled for othe rplatforms, we need to mark it as "test" so it won't be enabled when "experimental web platform features" is enabled, while it's enabled in tests. BUG=679303 ========== to ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, and disabled for other platforms, we need to mark it as "test" so it won't be enabled when "experimental web platform features" is enabled, while it's enabled in tests. BUG=679303 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by zqzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484848272658040,
"parent_rev": "63aa3c1e6e35803f1e9564ae1e2dd0cf74e58e2e", "commit_rev":
"054f78b8996675673b5dab034b5b7f2698e4e9d5"}
Message was sent while issue was closed.
Description was changed from ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, and disabled for other platforms, we need to mark it as "test" so it won't be enabled when "experimental web platform features" is enabled, while it's enabled in tests. BUG=679303 ========== to ========== [Blink>Media] Remove experimental flag for MediaSession from RuntimeEnabledFeatures As Media Session API is enabled by default on Android, and disabled for other platforms, we need to mark it as "test" so it won't be enabled when "experimental web platform features" is enabled, while it's enabled in tests. BUG=679303 Review-Url: https://codereview.chromium.org/2638413002 Cr-Commit-Position: refs/heads/master@{#444781} Committed: https://chromium.googlesource.com/chromium/src/+/054f78b8996675673b5dab034b5b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/054f78b8996675673b5dab034b5b... |
