Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2638353002: Update and unify nine-patch files for content suggestion and omnibox cards (Closed)

Created:
3 years, 11 months ago by Bernhard Bauer
Modified:
3 years, 11 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org, mdjones, Ted C
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update and unify nine-patch files for content suggestion and omnibox cards Screenshots: https://goo.gl/photos/GFukuPJesZCRHVaMA Change the calculation in CardViewHolder to not depend on the exact size of the card shadow, but get it instead from the drawable's padding. Review-Url: https://codereview.chromium.org/2638353002 Cr-Commit-Position: refs/heads/master@{#444785} Committed: https://chromium.googlesource.com/chromium/src/+/dfd4741a6504330ae91eea2a44f3b55eaa66430d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : x #

Patch Set 4 : rename #

Patch Set 5 : remove textbox #

Patch Set 6 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -25 lines) Patch
A chrome/android/java/res/drawable-hdpi/card_bottom.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/card_middle.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/card_single.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/card_top.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ntp_card_bottom.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ntp_card_middle.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ntp_card_single.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/ntp_card_top.9.png View 1 2 3 Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/textbox.9.png View 1 2 3 4 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/card_bottom.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/card_middle.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/card_single.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/card_top.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ntp_card_bottom.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ntp_card_middle.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ntp_card_single.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/ntp_card_top.9.png View 1 2 3 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/textbox.9.png View 1 2 3 4 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/card_bottom.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/card_middle.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/card_single.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/card_top.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/ntp_card_bottom.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/ntp_card_middle.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/ntp_card_single.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/ntp_card_top.9.png View 1 2 3 Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/textbox.9.png View 1 2 3 4 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/card_bottom.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/card_middle.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/card_single.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/card_top.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/ntp_card_bottom.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/ntp_card_middle.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/ntp_card_single.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/ntp_card_top.9.png View 1 2 3 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/textbox.9.png View 1 2 3 4 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/card_bottom.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/card_middle.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/card_single.9.png View 1 2 3 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/card_top.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/ntp_card_bottom.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/ntp_card_middle.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/ntp_card_single.9.png View 1 2 3 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/ntp_card_top.9.png View 1 2 3 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/textbox.9.png View 1 2 3 4 Binary file 0 comments Download
M chrome/android/java/res/layout/new_tab_page_action_card.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_layout.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_snippets_card.xml View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_status_card.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/toolbar_tablet.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 1 2 3 4 5 8 chunks +31 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
Bernhard Bauer
Michael, can you take a look (in particular at CardViewHolder)? Thanks!
3 years, 11 months ago (2017-01-19 10:44:20 UTC) #7
Michael van Ouwerkerk
lgtm \o/
3 years, 11 months ago (2017-01-19 11:43:14 UTC) #9
Bernhard Bauer
Thanks! +Matt, Ted FYI.
3 years, 11 months ago (2017-01-19 14:45:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638353002/80001
3 years, 11 months ago (2017-01-19 14:45:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/138615) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-19 14:47:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638353002/100001
3 years, 11 months ago (2017-01-19 17:26:59 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/dfd4741a6504330ae91eea2a44f3b55eaa66430d
3 years, 11 months ago (2017-01-19 18:04:17 UTC) #20
Theresa
I'm working on the new Android history page, which should have similar assets as the ...
3 years, 11 months ago (2017-01-21 00:01:13 UTC) #22
Bernhard Bauer
3 years, 11 months ago (2017-01-24 13:09:15 UTC) #23
Message was sent while issue was closed.
On 2017/01/21 00:01:13, Theresa wrote:
> I'm working on the new Android history page, which should have similar assets
as
> the NTP (or share assets where possible). It looks like the ntp_card* assets
are
> no longer used. Is that correct, and if so, can they be removed entirely?

Oops, yes. Those assets should have been removed in this CL; the card_*.9.png
assets are the ones to use going forward. I've sent out
https://codereview.chromium.org/2651653004/ to delete the old assets.

Powered by Google App Engine
This is Rietveld 408576698