Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 263833027: Fix two-way binding in polymer expressions. (Closed)

Created:
6 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix two-way binding in polymer expressions. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35868

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M pkg/polymer/test/event_handlers_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer_expressions/lib/eval.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/polymer_expressions/lib/polymer_expressions.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 1 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
6 years, 7 months ago (2014-05-06 22:20:16 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/263833027/diff/2/pkg/polymer_expressions/test/bindings_test.dart File pkg/polymer_expressions/test/bindings_test.dart (right): https://codereview.chromium.org/263833027/diff/2/pkg/polymer_expressions/test/bindings_test.dart#newcode118 pkg/polymer_expressions/test/bindings_test.dart:118: }).then(_nextMicrotask).then((_) { fyi -- I wonder if we ...
6 years, 7 months ago (2014-05-07 19:30:45 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/263833027/diff/2/pkg/polymer_expressions/test/bindings_test.dart File pkg/polymer_expressions/test/bindings_test.dart (right): https://codereview.chromium.org/263833027/diff/2/pkg/polymer_expressions/test/bindings_test.dart#newcode118 pkg/polymer_expressions/test/bindings_test.dart:118: }).then(_nextMicrotask).then((_) { On 2014/05/07 19:30:46, John Messerly wrote: > ...
6 years, 7 months ago (2014-05-07 19:58:14 UTC) #3
Jennifer Messerly
Nice. LGTM!
6 years, 7 months ago (2014-05-07 20:26:07 UTC) #4
Siggi Cherem (dart-lang)
6 years, 7 months ago (2014-05-07 20:39:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r35868 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698