Revert of Fix Views inline autocomplete with multi-char graphemes.

Revert of Fix Views inline autocomplete with multi-char graphemes. (https://codereview.chromium.org/252563003/)

Reason for revert:
Sorry to revert. After this patch the following test started failing on XP Tests (3):
RenderTextTest.MidGraphemeSelectionBounds

Log: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27345/steps/ui_unittests/logs/MidGraphemeSelectionBounds

Snippet from log:
c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(930): error: Value of: render_text->IsValidCursorIndex(1)
  Actual: true
Expected: false


Original issue's description:
> Fix Views inline autocomplete with multi-char graphemes.
> 
> Allow RenderText selection bounds amid multi-char graphemes.
> Add a consolidated IsValidLogicalIndex implementation.
> (this is less strict than the renamed IsValidCursorIndex)
> 
> Use adjacent cursor positions in MoveCursor as needed.
> (prevents invalid cursors when collapsing selections)
> 
> Skip painting empty glyph ranges on Windows.
> Add a unit test; minor cleanup and comment changes.
> 
> BUG=327903, 366786
> TEST=Search for "จำลอง" in the omnibox; enter "จ" and get a valid selection of the inline autocomplete text.
> R=asvitkine@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267752

TBR=asvitkine@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=327903, 366786
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267765

[falken, 2014-05-02 09:13:24]

Created Revert of Fix Views inline autocomplete with multi-char graphemes.

[falken, 2014-05-02 09:16:12]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-05-02 09:16:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/263833010/1

[commit-bot: I haz the power, 2014-05-02 09:17:28]

Change committed as 267765

[msw, 2014-05-02 09:22:04]

LGTM, thanks. Darn, our XP bots have exhibited font issues before.
I'll re-land excluding this test on XP, like some other RenderTextTests.

[Alexei Svitkine (slow), 2014-05-02 15:42:24]

SGTM.

The test uses Thai and Hindi scripts and we know our XP machines don't
always have language packs installed, so disabling on XP makes sense to me
here.


On Fri, May 2, 2014 at 5:22 AM, <msw@chromium.org> wrote:

> LGTM, thanks. Darn, our XP bots have exhibited font issues before.
> I'll re-land excluding this test on XP, like some other RenderTextTests.
>
> https://codereview.chromium.org/263833010/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.