ui/views/controls/textfield/textfield.cc - Issue 263833010: Revert of Fix Views inline autocomplete with multi-char graphemes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 263833010: Revert of Fix Views inline autocomplete with multi-char graphemes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 8645ace57eb8e73c5db77feec6b90394d3597cfb..c46ddd24b6d8b7bc5236e7e5fd83758772cb13ed 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -1325,7 +1325,7 @@

size_t text_index = composition_range.start() + index;

if (composition_range.end() <= text_index)

return false;

- if (!render_text->IsValidCursorIndex(text_index)) {

+ if (!render_text->IsCursorablePosition(text_index)) {

text_index = render_text->IndexOfAdjacentGrapheme(

text_index, gfx::CURSOR_BACKWARD);

}

« no previous file with comments | « ui/gfx/render_text_win.cc ('k') | no next file » | no next file with comments »