[keys] Make for-in great again.

[keys] Make for-in great again.

This CL fixes the check for empty elements in keys.cc. Previously we would
accidentally bail out of the fast path because the check would always fail.
As a consequence for-in loops that would initialize the enum-cache of an object
with own-only fast properties would never be optimized properly.

Review-Url: https://codereview.chromium.org/2638323002
Cr-Commit-Position: refs/heads/master@{#42454}
Committed: https://chromium.googlesource.com/v8/v8/+/6c7d51c296c9a9e90e817b85d49100d08c03d94f

[Camillo Bruni, 2017-01-18 09:50:00]

cbruni@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Camillo Bruni, 2017-01-18 09:50:01]

PTAL

[Benedikt Meurer, 2017-01-18 09:51:31]

LGTM % subject.

[Camillo Bruni, 2017-01-18 09:52:05]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2017-01-18 09:52:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 10:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:07:06]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Camillo Bruni, 2017-01-18 11:33:58]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 11:34:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 12:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:02:10]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-01-18 12:04:52]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2017-01-18 12:04:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2638323002/#ps40001
(title: "readding test")

[commit-bot: I haz the power, 2017-01-18 12:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 12:32:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484741092672700,
"parent_rev": "2af52484cd8e16b1571b1ed760d2d043cf0169b7", "commit_rev":
"6c7d51c296c9a9e90e817b85d49100d08c03d94f"}

[commit-bot: I haz the power, 2017-01-18 12:32:30]

Description was changed from

==========
[keys] Make for-in great again.

This CL fixes the check for empty elements in keys.cc. Previously we would
accidentally bail out of the fast path because the check would always fail.
As a consequence for-in loops that would initialize the enum-cache of an object
with own-only fast properties would never be optimized properly.
==========

to

==========
[keys] Make for-in great again.

This CL fixes the check for empty elements in keys.cc. Previously we would
accidentally bail out of the fast path because the check would always fail.
As a consequence for-in loops that would initialize the enum-cache of an object
with own-only fast properties would never be optimized properly.

Review-Url: https://codereview.chromium.org/2638323002
Cr-Commit-Position: refs/heads/master@{#42454}
Committed:
https://chromium.googlesource.com/v8/v8/+/6c7d51c296c9a9e90e817b85d49100d08c0...
==========

[commit-bot: I haz the power, 2017-01-18 12:32:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6c7d51c296c9a9e90e817b85d49100d08c0...