Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 7558a4c5aae1a5801885636d695407436719bcea..6f4c737b03c5004a6e1a2a90884fed9f4b15cdf2 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -655,11 +655,9 @@ TEST_F(ServiceWorkerVersionTest, IdleTimeout) {
// Adding a controllee resets the idle time.
version_->idle_time_ -= kOneSecond;
idle_time = version_->idle_time_;
- std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(
- 33 /* dummy render process id */, MSG_ROUTING_NONE /* render_frame_id */,
- 1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,
- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,
- helper_->context()->AsWeakPtr(), NULL));
+ std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(
+ 33 /* dummy render process id */, 1 /* dummy provider_id */,
+ true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr());
version_->AddControllee(host.get());
EXPECT_TRUE(version_->timeout_timer_.IsRunning());
EXPECT_LT(idle_time, version_->idle_time_);
@@ -1130,10 +1128,7 @@ TEST_F(ServiceWorkerFailToStartTest, RendererCrash) {
// Simulate renderer crash: do what
// ServiceWorkerDispatcherHost::OnFilterRemoved does.
- int process_id = helper_->mock_render_process_id();
- helper_->context()->RemoveAllProviderHostsForProcess(process_id);
- helper_->context()->embedded_worker_registry()->RemoveChildProcessSender(
- process_id);
+ helper_->context()->RemoveDispatcherHost(helper_->mock_render_process_id());
base::RunLoop().RunUntilIdle();
// Callback completed.
@@ -1343,10 +1338,7 @@ TEST_F(ServiceWorkerVersionTest, RendererCrashDuringEvent) {
// Simulate renderer crash: do what
// ServiceWorkerDispatcherHost::OnFilterRemoved does.
- int process_id = helper_->mock_render_process_id();
- helper_->context()->RemoveAllProviderHostsForProcess(process_id);
- helper_->context()->embedded_worker_registry()->RemoveChildProcessSender(
- process_id);
+ helper_->context()->RemoveDispatcherHost(helper_->mock_render_process_id());
base::RunLoop().RunUntilIdle();
// Callback completed.

Powered by Google App Engine
This is Rietveld 408576698