content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_test_utils.cc ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 74d61e747a8cabef77ec8f845eb222de9a953ec0..f9c23d4d5532ae765b62eb8b539975cd4aa1f50c 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -195,12 +195,10 @@ class ServiceWorkerURLRequestJobTest

version_->SetMainScriptHttpResponseInfo(http_info);

}

- std::unique_ptr<ServiceWorkerProviderHost> provider_host(

- new ServiceWorkerProviderHost(

- helper_->mock_render_process_id(), MSG_ROUTING_NONE, kProviderID,

- SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

- helper_->context()->AsWeakPtr(), nullptr));

+ std::unique_ptr<ServiceWorkerProviderHost> provider_host =

+ CreateProviderHostForWindow(

+ helper_->mock_render_process_id(), kProviderID,

+ true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr());

provider_host_ = provider_host->AsWeakPtr();

provider_host->SetDocumentUrl(GURL("https://example.com/"));

registration_->SetActiveVersion(version_);