Revert of Fix MenuController Heap-use-after-free

Revert of Fix MenuController Heap-use-after-free (patchset #2 id:20001 of https://codereview.chromium.org/2636293002/ )

Reason for revert:
Caused a memory leak in BookmarkBarViewTest7.DNDToDifferentMenu and BookmarkBarViewTest8.DNDBackToOriginatingMenu

See crbug.com/682109

Build link:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19037

Original issue's description:
> Fix MenuController Heap-use-after-free
> 
> MenuController applies a ref to ViewsDelegate, in order to prevent Chrome from
> shutting down while a menu is open. This ref is released as the menu is closing.
> 
> However it is possible for the release of the ref to lead to Chrome shutting
> down immediately. During this MenuController is deleted. However it was possible
> that MenuController would access the heap as the stack collapsed.
> 
> This change updates the menu closing process to detect the deletion and to
> shutdown cleanly.
> 
> TEST=MenuControllerTest.DestroyedDuringViewsRelease
> BUG=681462
> 
> Review-Url: https://codereview.chromium.org/2636293002
> Cr-Commit-Position: refs/heads/master@{#444203}
> Committed: https://chromium.googlesource.com/chromium/src/+/faaee985121bc612a5a79b03215a490f7f65d0eb

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681462
Review-Url: https://codereview.chromium.org/2638293002
Cr-Commit-Position: refs/heads/master@{#444281}
Committed: https://chromium.googlesource.com/chromium/src/+/cd4f55690437f7c40bfa710586781ec316cc889e

[meade_UTC10, 2017-01-18 05:18:15]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-01-18 05:18:16]

Created Revert of Fix MenuController Heap-use-after-free

[commit-bot: I haz the power, 2017-01-18 05:18:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 05:18:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484716695932700, "parent_rev":
"e20f96eac3b45fe5220f1e779533d6a0a7579d55", "commit_rev":
"cd4f55690437f7c40bfa710586781ec316cc889e"}

[commit-bot: I haz the power, 2017-01-18 05:20:18]

Description was changed from

==========
Revert of Fix MenuController Heap-use-after-free (patchset #2 id:20001 of
https://codereview.chromium.org/2636293002/ )

Reason for revert:
Caused a memory leak in BookmarkBarViewTest7.DNDToDifferentMenu and
BookmarkBarViewTest8.DNDBackToOriginatingMenu

See crbug.com/682109

Build link:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

Original issue's description:
> Fix MenuController Heap-use-after-free
> 
> MenuController applies a ref to ViewsDelegate, in order to prevent Chrome from
> shutting down while a menu is open. This ref is released as the menu is
closing.
> 
> However it is possible for the release of the ref to lead to Chrome shutting
> down immediately. During this MenuController is deleted. However it was
possible
> that MenuController would access the heap as the stack collapsed.
> 
> This change updates the menu closing process to detect the deletion and to
> shutdown cleanly.
> 
> TEST=MenuControllerTest.DestroyedDuringViewsRelease
> BUG=681462
> 
> Review-Url: https://codereview.chromium.org/2636293002
> Cr-Commit-Position: refs/heads/master@{#444203}
> Committed:
https://chromium.googlesource.com/chromium/src/+/faaee985121bc612a5a79b03215a...

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681462
==========

to

==========
Revert of Fix MenuController Heap-use-after-free (patchset #2 id:20001 of
https://codereview.chromium.org/2636293002/ )

Reason for revert:
Caused a memory leak in BookmarkBarViewTest7.DNDToDifferentMenu and
BookmarkBarViewTest8.DNDBackToOriginatingMenu

See crbug.com/682109

Build link:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

Original issue's description:
> Fix MenuController Heap-use-after-free
> 
> MenuController applies a ref to ViewsDelegate, in order to prevent Chrome from
> shutting down while a menu is open. This ref is released as the menu is
closing.
> 
> However it is possible for the release of the ref to lead to Chrome shutting
> down immediately. During this MenuController is deleted. However it was
possible
> that MenuController would access the heap as the stack collapsed.
> 
> This change updates the menu closing process to detect the deletion and to
> shutdown cleanly.
> 
> TEST=MenuControllerTest.DestroyedDuringViewsRelease
> BUG=681462
> 
> Review-Url: https://codereview.chromium.org/2636293002
> Cr-Commit-Position: refs/heads/master@{#444203}
> Committed:
https://chromium.googlesource.com/chromium/src/+/faaee985121bc612a5a79b03215a...

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681462

Review-Url: https://codereview.chromium.org/2638293002
Cr-Commit-Position: refs/heads/master@{#444281}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd4f55690437f7c40bfa71058678...
==========

[commit-bot: I haz the power, 2017-01-18 05:20:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd4f55690437f7c40bfa71058678...