Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2638253002: Remove references to missing blimp resource files (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to missing blimp resource files The CL https://codereview.chromium.org/2624903006 removed all the blimp client code, but omitted to remove the references to the resource files from the translation code. This CL updates the translation expectations for those files not to be there anymore. This CL is split out from https://codereview.chromium.org/2626423004/ as that CL will take some time to land, and this is currently breaking a build. BUG=681899, 677556 Review-Url: https://codereview.chromium.org/2638253002 Cr-Commit-Position: refs/heads/master@{#444246} Committed: https://chromium.googlesource.com/chromium/src/+/25a5d82dc299dce899828aa918e8e5dc6c023126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/gritsettings/translation_expectations.pyl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
nyquist
dpranke: PTAL
3 years, 11 months ago (2017-01-18 02:06:36 UTC) #4
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-18 02:07:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638253002/1
3 years, 11 months ago (2017-01-18 02:08:26 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 02:22:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25a5d82dc299dce899828aa918e8...

Powered by Google App Engine
This is Rietveld 408576698