[wasm] WebAssembly.Memory.grow() should handle the no instance case

[wasm] WebAssembly.Memory.grow() should handle the no instance case
 - Currently WebAssembly.Memory.grow() assumes that it always has an instance associated with it,
 fix to grow and reflect new size when no instance is associated with memory object.
 - Correctness fixes for the js api, throw range errors instead of generic errors

BUG=chromium:680938
R=bradnelson@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2638243002
Cr-Commit-Position: refs/heads/master@{#42432}
Committed: https://chromium.googlesource.com/v8/v8/+/6934db7ca7777db0799ec76b3fae811734e3c5c2

[gdeepti, 2017-01-18 01:55:23]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 01:55:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-01-18 02:17:47]

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js
File test/mjsunit/wasm/js-api.js (right):

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js...
test/mjsunit/wasm/js-api.js:396: // TODO(gdeepti): assertEq(buf.byteLength, 0);
Disabled for now because for the 0 case, we do not allocate a new buffer, second
case fails with guard pages enabled.

[commit-bot: I haz the power, 2017-01-18 02:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 02:20:43]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2017-01-18 02:35:37]

lgtm

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js
File test/mjsunit/wasm/js-api.js (right):

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js...
test/mjsunit/wasm/js-api.js:390: // TODO(gdeepti): assertEq(buf !== mem.buffer,
true);
Maybe say pending spec clarification (ideally ref the filled github issue)

[gdeepti, 2017-01-18 03:29:03]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 03:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 03:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:53:23]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-01-18 04:43:14]

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js
File test/mjsunit/wasm/js-api.js (right):

https://codereview.chromium.org/2638243002/diff/1/test/mjsunit/wasm/js-api.js...
test/mjsunit/wasm/js-api.js:390: // TODO(gdeepti): assertEq(buf !== mem.buffer,
true);
On 2017/01/18 02:35:37, bradnelson wrote:
> Maybe say pending spec clarification (ideally ref the filled github issue)

Done.

[gdeepti, 2017-01-18 04:43:24]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2017-01-18 04:43:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2638243002/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2017-01-18 04:43:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 04:45:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484714604604390,
"parent_rev": "d6a103d29d5906203517f55b0aba5dcf17f673b4", "commit_rev":
"6934db7ca7777db0799ec76b3fae811734e3c5c2"}

[commit-bot: I haz the power, 2017-01-18 04:45:11]

Description was changed from

==========
[wasm] WebAssembly.Memory.grow() should handle the no instance case
 - Currently WebAssembly.Memory.grow() assumes that it always has an instance
associated with it,
 fix to grow and reflect new size when no instance is associated with memory
object.
 - Correctness fixes for the js api, throw range errors instead of generic
errors

BUG=chromium:680938

R=bradnelson@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] WebAssembly.Memory.grow() should handle the no instance case
 - Currently WebAssembly.Memory.grow() assumes that it always has an instance
associated with it,
 fix to grow and reflect new size when no instance is associated with memory
object.
 - Correctness fixes for the js api, throw range errors instead of generic
errors

BUG=chromium:680938

R=bradnelson@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2638243002
Cr-Commit-Position: refs/heads/master@{#42432}
Committed:
https://chromium.googlesource.com/v8/v8/+/6934db7ca7777db0799ec76b3fae811734e...
==========

[commit-bot: I haz the power, 2017-01-18 04:45:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/6934db7ca7777db0799ec76b3fae811734e...