Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 263823008: Remove unneeded methods from PepperWidget for fullscreen pepper. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove unneeded methods from PepperWidget for fullscreen pepper. Most of these are already implemented in WebWidget to do nothing so not need to override anymore. isAcceleratedCompositingActive() is no longer called so remove it. Depends on: https://codereview.chromium.org/267863007/ R=jbauman, piman BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268309

Patch Set 1 #

Total comments: 2

Patch Set 2 : webwidget-pepper-cleanup: #

Patch Set 3 : webwidget-pepper-cleanup: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -70 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 2 4 chunks +2 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
danakj
6 years, 7 months ago (2014-05-02 22:58:45 UTC) #1
piman
lgtm https://codereview.chromium.org/263823008/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (left): https://codereview.chromium.org/263823008/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#oldcode318 content/renderer/render_widget_fullscreen_pepper.cc:318: return widget_->plugin() && widget_->is_compositing(); I think you can ...
6 years, 7 months ago (2014-05-02 23:38:53 UTC) #2
danakj
https://codereview.chromium.org/263823008/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (left): https://codereview.chromium.org/263823008/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#oldcode318 content/renderer/render_widget_fullscreen_pepper.cc:318: return widget_->plugin() && widget_->is_compositing(); On 2014/05/02 23:38:53, piman wrote: ...
6 years, 7 months ago (2014-05-02 23:40:58 UTC) #3
piman
lgtm
6 years, 7 months ago (2014-05-03 00:45:25 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-05 18:41:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/263823008/20001
6 years, 7 months ago (2014-05-05 18:41:52 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 19:35:54 UTC) #7
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 7 months ago (2014-05-05 19:42:30 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-05 19:43:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/263823008/40001
6 years, 7 months ago (2014-05-05 19:44:08 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 23:22:20 UTC) #11
Message was sent while issue was closed.
Change committed as 268309

Powered by Google App Engine
This is Rietveld 408576698