Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: content/renderer/render_widget_fullscreen_pepper.cc

Issue 263823008: Remove unneeded methods from PepperWidget for fullscreen pepper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: webwidget-pepper-cleanup: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget_fullscreen_pepper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget_fullscreen_pepper.cc
diff --git a/content/renderer/render_widget_fullscreen_pepper.cc b/content/renderer/render_widget_fullscreen_pepper.cc
index 9202c08eb3009838343fc8c68764595682a14ff5..bf85de27f9d193efffcf76aee8f2e521d36e2a5e 100644
--- a/content/renderer/render_widget_fullscreen_pepper.cc
+++ b/content/renderer/render_widget_fullscreen_pepper.cc
@@ -130,6 +130,8 @@ void FullscreenMouseLockDispatcher::SendUnlockMouseRequest() {
}
// WebWidget that simply wraps the pepper plugin.
+// TODO(piman): figure out IME and implement setComposition and friends if
+// necessary.
class PepperWidget : public WebWidget {
public:
explicit PepperWidget(RenderWidgetFullscreenPepper* widget)
@@ -147,9 +149,6 @@ class PepperWidget : public WebWidget {
return size_;
}
- virtual void willStartLiveResize() {
- }
-
virtual void resize(const WebSize& size) {
if (!widget_->plugin())
return;
@@ -161,21 +160,6 @@ class PepperWidget : public WebWidget {
widget_->Invalidate();
}
- virtual void willEndLiveResize() {
- }
-
- virtual void animate(double frameBeginTime) {
- }
-
- virtual void layout() {
- }
-
- virtual void setCompositorSurfaceReady() {
- }
-
- virtual void composite(bool finish) {
- }
-
virtual void themeChanged() {
NOTIMPLEMENTED();
}
@@ -268,56 +252,6 @@ class PepperWidget : public WebWidget {
return result;
}
- virtual void mouseCaptureLost() {
- }
-
- virtual void setFocus(bool focus) {
- }
-
- // TODO(piman): figure out IME and implement these if necessary.
- virtual bool setComposition(
- const WebString& text,
- const WebVector<WebCompositionUnderline>& underlines,
- int selectionStart,
- int selectionEnd) {
- return false;
- }
-
- virtual bool confirmComposition() {
- return false;
- }
-
- virtual bool compositionRange(size_t* location, size_t* length) {
- return false;
- }
-
- virtual bool confirmComposition(const WebString& text) {
- return false;
- }
-
- virtual WebTextInputType textInputType() {
- return blink::WebTextInputTypeNone;
- }
-
- virtual WebRect caretOrSelectionBounds() {
- return WebRect();
- }
-
- virtual bool selectionRange(WebPoint& start, WebPoint& end) const {
- return false;
- }
-
- virtual bool caretOrSelectionRange(size_t* location, size_t* length) {
- return false;
- }
-
- virtual void setTextDirection(WebTextDirection) {
- }
-
- virtual bool isAcceleratedCompositingActive() const {
- return widget_->plugin() && widget_->is_compositing();
- }
-
private:
RenderWidgetFullscreenPepper* widget_;
WebSize size_;
« no previous file with comments | « content/renderer/render_widget_fullscreen_pepper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698