Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2638223003:
Root layer scrolling: fix element ID collision. (Closed)
|
Created:
3 years, 11 months ago by skobes Modified:
3 years, 11 months ago Reviewers:
szager1 CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, cbiesinger Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoot layer scrolling: fix element ID collision.
We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same
CompositorElementId. This caused crashes when scrolling because we look up the
layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes
find the wrong one.
(In http://crrev.com/444407 I have also added a DCHECK for this condition in
the LayerTreeImpl.)
BUG=673963
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2638223003
Cr-Commit-Position: refs/heads/master@{#444525}
Committed: https://chromium.googlesource.com/chromium/src/+/5c1e664a82399b427466ab057edbc3d0cacc09d3
Patch Set 1 #
Total comments: 2
Patch Set 2 : update comment #Messages
Total messages: 17 (12 generated)
Description was changed from ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. BUG=673963 ========== to ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. (In http://crrev.com/2639103002 I am also adding a DCHECK for this condition in the LayerTreeImpl.) BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
skobes@chromium.org changed reviewers: + szager@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. (In http://crrev.com/2639103002 I am also adding a DCHECK for this condition in the LayerTreeImpl.) BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. (In http://crrev.com/444407 I have also added a DCHECK for this condition in the LayerTreeImpl.) BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
lgtm w/nit https://codereview.chromium.org/2638223003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp (right): https://codereview.chromium.org/2638223003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp:1139: // In RLS mode, LayoutView's scrolling contents layer gets this element ID. Please add to this comment that the ID gets assigned in CLM::updateElementIdAndCompositorMutableProperties.
https://codereview.chromium.org/2638223003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp (right): https://codereview.chromium.org/2638223003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp:1139: // In RLS mode, LayoutView's scrolling contents layer gets this element ID. On 2017/01/18 21:20:54, szager1 wrote: > Please add to this comment that the ID gets assigned in > CLM::updateElementIdAndCompositorMutableProperties. Done.
The CQ bit was checked by skobes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org Link to the patchset: https://codereview.chromium.org/2638223003/#ps20001 (title: "update comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484774682222980,
"parent_rev": "24f5635bb25006c6ac263c47e64c8b1cfa0b0f7a", "commit_rev":
"5c1e664a82399b427466ab057edbc3d0cacc09d3"}
Message was sent while issue was closed.
Description was changed from ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. (In http://crrev.com/444407 I have also added a DCHECK for this condition in the LayerTreeImpl.) BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Root layer scrolling: fix element ID collision. We were giving PLC::m_scrollLayer and CLM::m_scrollingContentsLayer the same CompositorElementId. This caused crashes when scrolling because we look up the layer by the element ID in LTHI::SetTreeLayerScrollOffsetMutated, and sometimes find the wrong one. (In http://crrev.com/444407 I have also added a DCHECK for this condition in the LayerTreeImpl.) BUG=673963 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2638223003 Cr-Commit-Position: refs/heads/master@{#444525} Committed: https://chromium.googlesource.com/chromium/src/+/5c1e664a82399b427466ab057edb... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5c1e664a82399b427466ab057edb... |
