Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2638213002: Ensure WebAPK installation always records the app banner installation event. (Closed)

Created:
3 years, 11 months ago by dominickn
Modified:
3 years, 11 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure WebAPK installation always records the app banner installation event. WebAPKs should always record the app banner DID_ADD_TO_HOMESCREEN event, which ensures that no banners are shown for an installed WebAPK and that an installed WebAPK is regarded as an important site. crrev.com/2473243002 erroneously stopped WebAPKs installed from the add to homescreen menu item from recording the event. This CL addresses the issue. BUG=682052 Review-Url: https://codereview.chromium.org/2638213002 Cr-Commit-Position: refs/heads/master@{#444222} Committed: https://chromium.googlesource.com/chromium/src/+/88a9a4f79d7fe6b05b2def6cbf158c935b1040b1

Patch Set 1 #

Patch Set 2 : Don't pollute banner statistics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dominickn
Xi - PTAL. This is to fix up an oversight where I accidentally stopped recording ...
3 years, 11 months ago (2017-01-17 23:43:39 UTC) #4
Xi Han
lgtm
3 years, 11 months ago (2017-01-17 23:55:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638213002/20001
3 years, 11 months ago (2017-01-18 00:23:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638213002/20001
3 years, 11 months ago (2017-01-18 00:38:51 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 01:20:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88a9a4f79d7fe6b05b2def6cbf15...

Powered by Google App Engine
This is Rietveld 408576698