Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2638203002: Convert AudioNode Audit tests to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioNode Audit tests to testharness These tests were converted using the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done audionode-disconnect-audioparam.html required some manual adjustments because it used testPassed directly. BUG=682011 TEST=audionode-connect-method-chaining.html,audionode-disconnect-audioparam.html,audionode-disconnect.html Review-Url: https://codereview.chromium.org/2638203002 Cr-Commit-Position: refs/heads/master@{#445766} Committed: https://chromium.googlesource.com/chromium/src/+/15a29620cf841e864eefd270fd8d5ecb7e673eb0

Patch Set 1 #

Messages

Total messages: 17 (9 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-23 20:54:43 UTC) #3
hongchan
lgtm
3 years, 11 months ago (2017-01-23 21:48:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638203002/1
3 years, 11 months ago (2017-01-24 15:52:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/198967) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 15:56:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638203002/1
3 years, 11 months ago (2017-01-24 16:30:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/199646)
3 years, 11 months ago (2017-01-24 16:34:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638203002/1
3 years, 11 months ago (2017-01-24 18:37:02 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 18:45:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15a29620cf841e864eefd270fd8d...

Powered by Google App Engine
This is Rietveld 408576698