Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: pkg/analyzer/lib/src/summary/link.dart

Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/type_system.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/link.dart
diff --git a/pkg/analyzer/lib/src/summary/link.dart b/pkg/analyzer/lib/src/summary/link.dart
index e261675b485dec79507eb4912905ad22a4b666ca..a685504be5cbc9ab8b18aacfae880c24708a91de 100644
--- a/pkg/analyzer/lib/src/summary/link.dart
+++ b/pkg/analyzer/lib/src/summary/link.dart
@@ -247,7 +247,7 @@ EntityRefBuilder _createLinkedType(
}
DartType _dynamicIfNull(DartType type) {
- if (type == null || type.isBottom || type.isVoid) {
+ if (type == null || type.isBottom || type.isDartCoreNull || type.isVoid) {
return DynamicTypeImpl.instance;
}
return type;
@@ -2006,7 +2006,7 @@ class ExprTypeComputer {
stack.add(typeProvider.symbolType);
break;
case UnlinkedExprOperation.pushNull:
- stack.add(BottomTypeImpl.instance);
+ stack.add(typeProvider.nullType);
break;
case UnlinkedExprOperation.pushReference:
_doPushReference();
« no previous file with comments | « pkg/analyzer/lib/src/generated/type_system.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698