pkg/analyzer/lib/src/generated/type_system.dart - Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer. (Closed)

Patch Set: Fixes for review comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/type_system.dart

diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart

index ed117afc63938a632ccaf1cd4f18d1bdd1d801e2..93dda91c0b7731ea8d5c7dff0bd8e6e6dbf572ff 100644

--- a/pkg/analyzer/lib/src/generated/type_system.dart

+++ b/pkg/analyzer/lib/src/generated/type_system.dart

@@ -24,7 +24,7 @@ import 'package:analyzer/src/generated/utilities_general.dart'

show JenkinsSmiHash;

bool _isBottom(DartType t, {bool dynamicIsBottom: false}) {

- return (t.isDynamic && dynamicIsBottom) || t.isBottom;

+ return (t.isDynamic && dynamicIsBottom) || t.isBottom || t.isDartCoreNull;

}

bool _isTop(DartType t, {bool dynamicIsBottom: false}) {