Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2638173002: Compact the symbol table when creating core snapshots or JIT app snapshots. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compact the symbol table when creating core snapshots or JIT app snapshots. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/dcb1d51f333e5bb8343333b7f9fcb7c605e92dee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M runtime/vm/dart_api_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/symbols.cc View 3 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
With dart2js VMIsolate(CodeSize): 0 Isolate(CodeSize): 7282554 ReadOnlyData(CodeSize): 4024880 Instructions(CodeSize): 5859552 Total(CodeSize): 17166986 VM Isolate: Number ...
3 years, 11 months ago (2017-01-17 20:59:00 UTC) #2
siva
lgtm
3 years, 11 months ago (2017-01-18 23:31:53 UTC) #3
rmacnak
3 years, 11 months ago (2017-01-19 18:49:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcb1d51f333e5bb8343333b7f9fcb7c605e92dee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698