Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2638173002: Compact the symbol table when creating core snapshots or JIT app snapshots. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 22e23911615cecd9d72dcd545b018d2983ff3b1b..547a23d0e41ed19cf4f5eae26724da4e86f6db69 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1577,6 +1577,8 @@ Dart_CreateSnapshot(uint8_t** vm_isolate_snapshot_buffer,
I->heap()->IterateObjects(&check_canonical);
#endif // #if defined(DEBUG)
+ Symbols::Compact(I);
+
FullSnapshotWriter writer(Snapshot::kCore, vm_isolate_snapshot_buffer,
isolate_snapshot_buffer, ApiReallocate,
NULL /* instructions_writer */);
@@ -6765,6 +6767,8 @@ Dart_CreateAppJITSnapshotAsBlobs(uint8_t** isolate_snapshot_buffer,
}
I->StopBackgroundCompiler();
+ Symbols::Compact(I);
+
NOT_IN_PRODUCT(TimelineDurationScope tds2(T, Timeline::GetIsolateStream(),
"WriteAppJITSnapshot"));
BlobInstructionsWriter instructions_writer(instructions_blob_buffer,
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698