Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2638093002: Don't crash debug builds for full allocator. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't crash debug builds for full allocator. The "full" error is caused by things outside of the control of this code so don't crash because of it. BUG=675600 Review-Url: https://codereview.chromium.org/2638093002 Cr-Commit-Position: refs/heads/master@{#444101} Committed: https://chromium.googlesource.com/chromium/src/+/734c246453da8b9a38d7266fe2bbd272037c99e8

Patch Set 1 #

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
bcwhite
3 years, 11 months ago (2017-01-17 16:42:25 UTC) #2
Alexei Svitkine (slow)
LGTM Can you add a comment above the if to explain the reasoning?
3 years, 11 months ago (2017-01-17 16:48:01 UTC) #3
bcwhite
On 2017/01/17 16:48:01, Alexei Svitkine (slow) wrote: > LGTM > > Can you add a ...
3 years, 11 months ago (2017-01-17 17:01:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638093002/20001
3 years, 11 months ago (2017-01-17 18:45:52 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 18:52:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/734c246453da8b9a38d7266fe2bb...

Powered by Google App Engine
This is Rietveld 408576698