|
|
Reverts the following two commits:
"Add support for the new function-type syntax." # e4999a631093690febb2eb90cbdbe1f9d5183455.
"In function-type test: remove unused variables, make type stronger." # 02ffb3b1403d4c5ee87435aa7eb9da39c01a5759.
Reason to revert:
We found user code breaks because of ambiguous cases like this:
```
class Function extends Foo {
Function() : super();
}
```
Today this fails when trying to parse the constructor.
We need to:
* indicate this is not allowed anymore (probably at the class declaration)
* allow it until we are ready to make it a breaking change (by maybe
adding a special exception to allow this ambiguity in the syntax).
* consider the language change to see whether we can prevent the breaking
change if we use a different keyword.
BUG=
R=floitsch@google.com
Committed: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+140 lines, -1613 lines) |
Patch |
 |
M |
pkg/compiler/lib/src/common/resolution.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/elements/elements.dart
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/elements/modelx.dart
|
View
|
|
2 chunks |
+1 line, -10 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/elements/resolution_types.dart
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/kernel/kernel_visitor.dart
|
View
|
|
3 chunks |
+2 lines, -18 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/native/behavior.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/parser/element_listener.dart
|
View
|
|
4 chunks |
+8 lines, -25 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/parser/listener.dart
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/parser/node_listener.dart
|
View
|
|
4 chunks |
+7 lines, -51 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/parser/parser.dart
|
View
|
|
13 chunks |
+50 lines, -220 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/parser/partial_parser.dart
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/class_hierarchy.dart
|
View
|
|
6 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/constructors.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/resolution_common.dart
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/signatures.dart
|
View
|
|
6 chunks |
+6 lines, -19 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/type_resolver.dart
|
View
|
|
10 chunks |
+15 lines, -193 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/resolution/typedefs.dart
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/serialization/equivalence.dart
|
View
|
|
3 chunks |
+3 lines, -14 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/serialization/modelz.dart
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/ssa/graph_builder.dart
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/tokens/token.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/tree/nodes.dart
|
View
|
|
18 chunks |
+14 lines, -95 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/tree/prettyprint.dart
|
View
|
|
4 chunks |
+7 lines, -19 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/tree/unparser.dart
|
View
|
|
3 chunks |
+3 lines, -14 lines |
0 comments
|
Download
|
 |
M |
pkg/compiler/lib/src/use_unused_api.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
tests/compiler/dart2js/resolver_test.dart
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
D |
tests/language/generalized_function_type_test.dart
|
View
|
|
1 chunk |
+0 lines, -792 lines |
0 comments
|
Download
|
 |
D |
tests/language/generic_function_typedef2_test.dart
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
 |
D |
tests/language/generic_function_typedef_test.dart
|
View
|
|
1 chunk |
+0 lines, -24 lines |
0 comments
|
Download
|
 |
M |
tests/language/language.status
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
tests/language/language_analyzer2.status
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
tests/language/language_dart2js.status
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
tests/language/language_kernel.status
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|