Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: pkg/compiler/lib/src/serialization/equivalence.dart

Issue 2638063003: Reverts the following two commits: (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Functions for asserting equivalence across serialization. 5 /// Functions for asserting equivalence across serialization.
6 6
7 library dart2js.serialization.equivalence; 7 library dart2js.serialization.equivalence;
8 8
9 import '../closure.dart'; 9 import '../closure.dart';
10 import '../common/resolution.dart'; 10 import '../common/resolution.dart';
(...skipping 1947 matching lines...) Expand 10 before | Expand all | Expand 10 after
1958 testTokens(node1, node2, 'finallyKeyword', node1.finallyKeyword, 1958 testTokens(node1, node2, 'finallyKeyword', node1.finallyKeyword,
1959 node2.finallyKeyword) && 1959 node2.finallyKeyword) &&
1960 testNodes(node1, node2, 'tryBlock', node1.tryBlock, node2.tryBlock) && 1960 testNodes(node1, node2, 'tryBlock', node1.tryBlock, node2.tryBlock) &&
1961 testNodes(node1, node2, 'catchBlocks', node1.catchBlocks, 1961 testNodes(node1, node2, 'catchBlocks', node1.catchBlocks,
1962 node2.catchBlocks) && 1962 node2.catchBlocks) &&
1963 testNodes(node1, node2, 'finallyBlock', node1.finallyBlock, 1963 testNodes(node1, node2, 'finallyBlock', node1.finallyBlock,
1964 node2.finallyBlock); 1964 node2.finallyBlock);
1965 } 1965 }
1966 1966
1967 @override 1967 @override
1968 bool visitNominalTypeAnnotation( 1968 bool visitTypeAnnotation(TypeAnnotation node1, TypeAnnotation node2) {
1969 NominalTypeAnnotation node1, NominalTypeAnnotation node2) {
1970 return testNodes( 1969 return testNodes(
1971 node1, node2, 'typeName', node1.typeName, node2.typeName) && 1970 node1, node2, 'typeName', node1.typeName, node2.typeName) &&
1972 testNodes(node1, node2, 'typeArguments', node1.typeArguments, 1971 testNodes(node1, node2, 'typeArguments', node1.typeArguments,
1973 node2.typeArguments); 1972 node2.typeArguments);
1974 } 1973 }
1975 1974
1976 @override 1975 @override
1977 bool visitFunctionTypeAnnotation(
1978 FunctionTypeAnnotation node1, FunctionTypeAnnotation node2) {
1979 return testNodes(
1980 node1, node2, 'returnType', node1.returnType, node2.returnType) &&
1981 testNodes(node1, node2, 'formals', node1.formals, node2.formals) &&
1982 testNodes(node1, node2, 'typeParameters', node1.typeParameters,
1983 node2.typeParameters);
1984 }
1985
1986 @override
1987 bool visitTypeVariable(TypeVariable node1, TypeVariable node2) { 1976 bool visitTypeVariable(TypeVariable node1, TypeVariable node2) {
1988 return testNodes(node1, node2, 'name', node1.name, node2.name) && 1977 return testNodes(node1, node2, 'name', node1.name, node2.name) &&
1989 testNodes(node1, node2, 'bound', node1.bound, node2.bound); 1978 testNodes(node1, node2, 'bound', node1.bound, node2.bound);
1990 } 1979 }
1991 1980
1992 @override 1981 @override
1993 bool visitTypedef(Typedef node1, Typedef node2) { 1982 bool visitTypedef(Typedef node1, Typedef node2) {
1994 return testTokens(node1, node2, 'typedefKeyword', node1.typedefKeyword, 1983 return testTokens(node1, node2, 'typedefKeyword', node1.typedefKeyword,
1995 node2.typedefKeyword) && 1984 node2.typedefKeyword) &&
1996 testTokens(node1, node2, 'endToken', node1.endToken, node2.endToken) && 1985 testTokens(node1, node2, 'endToken', node1.endToken, node2.endToken) &&
1997 testNodes( 1986 testNodes(
1998 node1, node2, 'returnType', node1.returnType, node2.returnType) && 1987 node1, node2, 'returnType', node1.returnType, node2.returnType) &&
1999 testNodes(node1, node2, 'name', node1.name, node2.name) && 1988 testNodes(node1, node2, 'name', node1.name, node2.name) &&
2000 testNodes(node1, node2, 'typeParameters', node1.templateParameters, 1989 testNodes(node1, node2, 'typeParameters', node1.typeParameters,
2001 node2.templateParameters) && 1990 node2.typeParameters) &&
2002 testNodes(node1, node2, 'formals', node1.formals, node2.formals); 1991 testNodes(node1, node2, 'formals', node1.formals, node2.formals);
2003 } 1992 }
2004 1993
2005 @override 1994 @override
2006 bool visitVariableDefinitions( 1995 bool visitVariableDefinitions(
2007 VariableDefinitions node1, VariableDefinitions node2) { 1996 VariableDefinitions node1, VariableDefinitions node2) {
2008 return testNodes( 1997 return testNodes(
2009 node1, node2, 'metadata', node1.metadata, node2.metadata) && 1998 node1, node2, 'metadata', node1.metadata, node2.metadata) &&
2010 testNodes(node1, node2, 'type', node1.type, node2.type) && 1999 testNodes(node1, node2, 'type', node1.type, node2.type) &&
2011 testNodes( 2000 testNodes(
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
2056 } 2045 }
2057 2046
2058 bool areMetadataAnnotationsEquivalent( 2047 bool areMetadataAnnotationsEquivalent(
2059 MetadataAnnotation metadata1, MetadataAnnotation metadata2) { 2048 MetadataAnnotation metadata1, MetadataAnnotation metadata2) {
2060 if (metadata1 == metadata2) return true; 2049 if (metadata1 == metadata2) return true;
2061 if (metadata1 == null || metadata2 == null) return false; 2050 if (metadata1 == null || metadata2 == null) return false;
2062 return areElementsEquivalent( 2051 return areElementsEquivalent(
2063 metadata1.annotatedElement, metadata2.annotatedElement) && 2052 metadata1.annotatedElement, metadata2.annotatedElement) &&
2064 areConstantsEquivalent(metadata1.constant, metadata2.constant); 2053 areConstantsEquivalent(metadata1.constant, metadata2.constant);
2065 } 2054 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/resolution/typedefs.dart ('k') | pkg/compiler/lib/src/serialization/modelz.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698