Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 263803007: Make some l10n values on Options independent from ENABLE_FULL_PRINTING. (Closed)

Created:
6 years, 7 months ago by Alexey Kuzmin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make some l10n values on Options independent from ENABLE_FULL_PRINTING. "showSetDefault" and "allowAdvancedSettings" should not be set via RegisterCloudPrintValues call since they are not related to Google Cloud Print. R=bcwhite@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278752

Patch Set 1 #

Patch Set 2 : Rebase onto latest LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alexey Kuzmin
6 years, 7 months ago (2014-05-02 22:44:09 UTC) #1
Alexey Kuzmin
6 years, 7 months ago (2014-05-02 22:46:48 UTC) #2
Alexey Kuzmin
+ arv@chromium.org as reviewer Issue was created 10 days ago. Is there any chance that ...
6 years, 7 months ago (2014-05-13 17:05:35 UTC) #3
Alexey Kuzmin
On 2014/05/13 17:05:35, Alexey Kuzmin wrote: > + mailto:arv@chromium.org as reviewer > > Issue was ...
6 years, 6 months ago (2014-06-09 13:49:59 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 6 months ago (2014-06-13 15:44:08 UTC) #5
arv (Not doing code reviews)
On 2014/06/09 13:49:59, Alexey Kuzmin wrote: > On 2014/05/13 17:05:35, Alexey Kuzmin wrote: > > ...
6 years, 6 months ago (2014-06-13 15:45:18 UTC) #6
Alexey Kuzmin
The CQ bit was checked by jj-spoon@yandex-team.ru
6 years, 6 months ago (2014-06-20 11:33:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jj-spoon@yandex-team.ru/263803007/1
6 years, 6 months ago (2014-06-20 11:37:49 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 13:08:33 UTC) #9
Alexey Kuzmin
The CQ bit was checked by jj-spoon@yandex-team.ru
6 years, 6 months ago (2014-06-20 13:11:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jj-spoon@yandex-team.ru/263803007/20001
6 years, 6 months ago (2014-06-20 13:13:33 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:37:34 UTC) #12
Message was sent while issue was closed.
Change committed as 278752

Powered by Google App Engine
This is Rietveld 408576698