Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 263803007: Make some l10n values on Options independent from ENABLE_FULL_PRINTING. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase onto latest LKGR Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 2e462a3d804e4e6ca48e65b78fbe50109e31582f..0b20a27c1e533891fad2663f2ce31c122fbb03c0 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -610,6 +610,10 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
RegisterTitle(values, "thirdPartyImeConfirmOverlay",
IDS_OPTIONS_SETTINGS_LANGUAGES_THIRD_PARTY_WARNING_TITLE);
#endif
+
+ values->SetBoolean("showSetDefault", ShouldShowSetDefaultBrowser());
+
+ values->SetBoolean("allowAdvancedSettings", ShouldAllowAdvancedSettings());
}
#if defined(ENABLE_FULL_PRINTING)
@@ -619,9 +623,6 @@ void BrowserOptionsHandler::RegisterCloudPrintValues(
l10n_util::GetStringFUTF16(
IDS_CLOUD_PRINT_CHROMEOS_OPTION_LABEL,
l10n_util::GetStringUTF16(IDS_GOOGLE_CLOUD_PRINT)));
-
- values->SetBoolean("showSetDefault", ShouldShowSetDefaultBrowser());
- values->SetBoolean("allowAdvancedSettings", ShouldAllowAdvancedSettings());
}
#endif // defined(ENABLE_FULL_PRINTING)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698