Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Issue 2638003002: [wasm] Check for malformed mutability (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Check for malformed mutability Fixes failure on spec test globals.wast. Review-Url: https://codereview.chromium.org/2638003002 Cr-Commit-Position: refs/heads/master@{#42406} Committed: https://chromium.googlesource.com/v8/v8/+/8863f9f258623ecc3304f6e3156c829e8960f8a4

Patch Set 1 #

Patch Set 2 : Add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/wasm/module-decoder.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
rossberg
PTAL
3 years, 11 months ago (2017-01-17 12:22:47 UTC) #3
titzer
Can you add a test in module-decoder-unittest.cc for this?
3 years, 11 months ago (2017-01-17 12:42:01 UTC) #4
titzer
On 2017/01/17 12:42:01, titzer wrote: > Can you add a test in module-decoder-unittest.cc for this? ...
3 years, 11 months ago (2017-01-17 12:47:21 UTC) #5
rossberg
On 2017/01/17 12:42:01, titzer wrote: > Can you add a test in module-decoder-unittest.cc for this? ...
3 years, 11 months ago (2017-01-17 13:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638003002/20001
3 years, 11 months ago (2017-01-17 13:06:48 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:35:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8863f9f258623ecc3304f6e3156c829e896...

Powered by Google App Engine
This is Rietveld 408576698