Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG=681780
Review-Url: https://codereview.chromium.org/2637983002
Cr-Commit-Position: refs/heads/master@{#444039}
Committed: https://chromium.googlesource.com/chromium/src/+/51d4cf487be9accac21945f3ec095f5d7df49dc0

[Olivier, 2017-01-17 10:37:34]

Description was changed from

==========
Reading List: Show "Read Later on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG=681780
==========

to

==========
Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG=681780
==========

[Olivier, 2017-01-17 10:37:54]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org, marq@chromium.org

[gambard, 2017-01-17 10:39:05]

lgtm but do you want to remove the "data" protocol only for ReadingList? What
about the other context menu actions?

[Olivier, 2017-01-17 10:44:36]

I don't know for the other actions, so I don't want to change their behavior.
May be mark has an idea on this?

[marq (ping after 24h), 2017-01-17 10:53:36]

On 2017/01/17 10:44:36, Olivier Robin wrote:
> I don't know for the other actions, so I don't want to change their behavior.
> May be mark has an idea on this?

I think we want to be able to open in a new tab, or open in an incognito tab,
URLs with any scheme.

[marq (ping after 24h), 2017-01-17 10:54:11]

Also, LGTM for BVC change.

[Olivier, 2017-01-17 10:55:02]

Thanks marq.
Can you review this CL as a BVC owner then?

[Olivier, 2017-01-17 13:23:14]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-01-17 13:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 13:32:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484659394562590, "parent_rev":
"f88a71b51a4309aa32690990d8c349214428fe1c", "commit_rev":
"51d4cf487be9accac21945f3ec095f5d7df49dc0"}

[commit-bot: I haz the power, 2017-01-17 13:33:06]

Description was changed from

==========
Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG=681780
==========

to

==========
Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG=681780

Review-Url: https://codereview.chromium.org/2637983002
Cr-Commit-Position: refs/heads/master@{#444039}
Committed:
https://chromium.googlesource.com/chromium/src/+/51d4cf487be9accac21945f3ec09...
==========

[commit-bot: I haz the power, 2017-01-17 13:33:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51d4cf487be9accac21945f3ec09...