Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2637983002: Reading List: Show "Read Later" only on HTTP or HTTPS scheme. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reading List: Show "Read Later" only on HTTP or HTTPS scheme. Current test allow data scheme which should not be allowed in Reading List. BUG=681780 Review-Url: https://codereview.chromium.org/2637983002 Cr-Commit-Position: refs/heads/master@{#444039} Committed: https://chromium.googlesource.com/chromium/src/+/51d4cf487be9accac21945f3ec095f5d7df49dc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Olivier
3 years, 11 months ago (2017-01-17 10:37:54 UTC) #3
gambard
lgtm but do you want to remove the "data" protocol only for ReadingList? What about ...
3 years, 11 months ago (2017-01-17 10:39:05 UTC) #4
Olivier
I don't know for the other actions, so I don't want to change their behavior. ...
3 years, 11 months ago (2017-01-17 10:44:36 UTC) #5
marq (ping after 24h)
On 2017/01/17 10:44:36, Olivier Robin wrote: > I don't know for the other actions, so ...
3 years, 11 months ago (2017-01-17 10:53:36 UTC) #6
marq (ping after 24h)
Also, LGTM for BVC change.
3 years, 11 months ago (2017-01-17 10:54:11 UTC) #7
Olivier
Thanks marq. Can you review this CL as a BVC owner then?
3 years, 11 months ago (2017-01-17 10:55:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637983002/1
3 years, 11 months ago (2017-01-17 13:23:27 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:33:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51d4cf487be9accac21945f3ec09...

Powered by Google App Engine
This is Rietveld 408576698