Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2637923002: Remove some dead fields from isolate.h (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove some dead fields from isolate.h R=jochen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2637923002 Cr-Commit-Position: refs/heads/master@{#42391} Committed: https://chromium.googlesource.com/v8/v8/+/b5409ea2e058080f89df87b2d83c0f5cfb86cca0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
PTAL, all red.
3 years, 11 months ago (2017-01-16 18:11:04 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-16 18:15:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637923002/1
3 years, 11 months ago (2017-01-17 09:29:33 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 09:31:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b5409ea2e058080f89df87b2d83c0f5cfb8...

Powered by Google App Engine
This is Rietveld 408576698