Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2637873002: Annotate template and factory methods as not executing script (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Annotate template and factory methods as not executing script BUG=v8:5830 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2637873002 Cr-Commit-Position: refs/heads/master@{#42415} Committed: https://chromium.googlesource.com/v8/v8/+/29aaefa16acb4aad6b93bb5f7ad74aaf5c8ca293

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -66 lines) Patch
M src/api.cc View 1 2 67 chunks +79 lines, -66 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-16 16:10:18 UTC) #1
Yang
On 2017/01/16 16:10:18, jochen wrote: lgtm.
3 years, 11 months ago (2017-01-17 09:55:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637873002/20001
3 years, 11 months ago (2017-01-17 13:28:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/11290)
3 years, 11 months ago (2017-01-17 13:34:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637873002/40001
3 years, 11 months ago (2017-01-17 14:51:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:22:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/29aaefa16acb4aad6b93bb5f7ad74aaf5c8...

Powered by Google App Engine
This is Rietveld 408576698