Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/autofill/core/common/password_form.h

Issue 2637823002: [Password Generation] Send votes about confirmation fields (Closed)
Patch Set: Changes addressed to reviewer comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index be74b85ce4da8474ac879cb6844ec2699eb7298b..ff7e126a460e5c2aca97ce72c8ee610a260473c7 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -165,6 +165,11 @@ struct PasswordForm {
// element corresponding to the new password. Optional, and not persisted.
base::string16 new_password_element;
+ // If |new_password_element| is defined and there is another password element
+ // with the same user input, keep the name of the element in
dvadym 2017/01/17 16:32:21 Nit: I'd propose to simplify this comment, somethi
kolos1 2017/01/18 09:15:14 Done.
+ // |password_confirmation_element|.
+ base::string16 confirmation_password_element;
+
// The new password. Optional, and not persisted.
base::string16 new_password_value;
« no previous file with comments | « components/autofill/core/browser/field_types.h ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698