[Password Generation] Send votes about confirmation fields

components/autofill/core/common/password_form.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 147 matching lines @@
   base::string16 password_value;
 
   // Whether the password value is the same as specified in the "value"
   // attribute of the input element. Only used in the renderer.
   bool password_value_is_default;
 
   // If the form was a sign-up or a change password form, the name of the input
   // element corresponding to the new password. Optional, and not persisted.
   base::string16 new_password_element;
 
+  // If |new_password_element| is defined and there is another password element
+  // with the same user input, keep the name of the element in

[dvadym, 2017/01/17 16:32:21]

Nit: I'd propose to simplify this comment, something like this:

The confirmation password element. Optional, only set on form parsing, and not
persisted.

[kolos1, 2017/01/18 09:15:14]

Done.

+  // |password_confirmation_element|.
+  base::string16 confirmation_password_element;
+
   // The new password. Optional, and not persisted.
   base::string16 new_password_value;
 
   // Whether the password value is the same as specified in the "value"
   // attribute of the input element. Only used in the renderer.
   bool new_password_value_is_default;
 
   // Whether the |new_password_element| has an autocomplete=new-password
   // attribute. This is only used in parsed HTML forms.
   bool new_password_marked_by_site;
@@ skipping 120 matching lines @@
 };
 
 // For testing.
 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__