Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2637793002: objects.h splitting side work: move scopeinfo.cc to its logical place. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

objects.h splitting side work: move scopeinfo.cc to its logical place. src/ast/scopeinfo.cc -> src/objects/scope-info.cc BUG=v8:5402 Review-Url: https://codereview.chromium.org/2637793002 Cr-Commit-Position: refs/heads/master@{#42357} Committed: https://chromium.googlesource.com/v8/v8/+/4fb60b215801db70c694a799e735b64bfead59bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1022 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D src/ast/scopeinfo.cc View 1 chunk +0 lines, -981 lines 0 comments Download
A + src/objects/scope-info.cc View 20 chunks +5 lines, -39 lines 0 comments Download
M src/v8.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
marja
ptal
3 years, 11 months ago (2017-01-16 07:28:27 UTC) #2
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-16 09:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637793002/1
3 years, 11 months ago (2017-01-16 10:05:43 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 10:31:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4fb60b215801db70c694a799e735b64bfea...

Powered by Google App Engine
This is Rietveld 408576698