Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2637703004: Delay all exceptions in WebAssembly.instantiate (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delay all exceptions in WebAssembly.instantiate R=titzer@chromium.org BUG=v8:5818 Review-Url: https://codereview.chromium.org/2637703004 Cr-Commit-Position: refs/heads/master@{#42372} Committed: https://chromium.googlesource.com/v8/v8/+/ef555d08a976e5f2d22fb76d6538d53a90d052f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +18 lines, -15 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rossberg
3 years, 11 months ago (2017-01-16 12:40:26 UTC) #1
titzer
On 2017/01/16 12:40:26, rossberg wrote: LGTM
3 years, 11 months ago (2017-01-16 12:45:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637703004/1
3 years, 11 months ago (2017-01-16 12:48:26 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 13:13:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ef555d08a976e5f2d22fb76d6538d53a90d...

Powered by Google App Engine
This is Rietveld 408576698