Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2637703003: Refactor GNI files in preparation for assembly (Closed)

Created:
3 years, 11 months ago by hta - Chromium
Modified:
3 years, 11 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor GNI files in preparation for assembly This CL moves around the definitions of the OpenH264 source files, in preparation for adding H.264 assembly. It is a spin-off from CL/2585733002 BUG=600399 Review-Url: https://codereview.chromium.org/2637703003 Cr-Commit-Position: refs/heads/master@{#443869} Committed: https://chromium.googlesource.com/chromium/src/+/e1926525b79fdbd181867190c7ef012e7f594e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -203 lines) Patch
M third_party/openh264/BUILD.gn View 4 chunks +7 lines, -203 lines 0 comments Download
A third_party/openh264/openh264_sources.gni View 1 chunk +289 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hta - Chromium
Looks OK?
3 years, 11 months ago (2017-01-16 10:30:54 UTC) #5
hbos_chromium
LOTM lgtm
3 years, 11 months ago (2017-01-16 11:17:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637703003/1
3 years, 11 months ago (2017-01-16 11:51:20 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 11:55:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1926525b79fdbd181867190c7ef...

Powered by Google App Engine
This is Rietveld 408576698