Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2637563002: [Offline Pages] Snapshotting on timeout of last retry. (Closed)
Patch Set: rebasing and a cl format Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index 2bf511a66d992509ba0bf92c682e0e22dc883d88..a04ee0b0b3e6cbd7138e3fdae40f12ba02845c8e 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -123,6 +123,12 @@ void BackgroundLoaderOffliner::Cancel() {
ResetState();
}
+bool BackgroundLoaderOffliner::HandleTimeout(const SavePageRequest& request) {
+ // TODO(romax) device if we want to also take a snapshot on the last timeout
Pete Williamson 2017/02/24 22:29:03 Nit: Device -> Decide
+ // for the background loader offliner.
+ return false;
+}
+
void BackgroundLoaderOffliner::DidStopLoading() {
if (!pending_request_.get()) {
DVLOG(1) << "DidStopLoading called even though no pending request.";

Powered by Google App Engine
This is Rietveld 408576698