[Offline Pages] Snapshotting on timeout of last retry.

chrome/browser/android/offline_pages/background_loader_offliner.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/background_loader_offliner.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/sys_info.h"
 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
 #include "chrome/browser/android/offline_pages/offliner_helper.h"
@@ skipping 105 matching lines @@
     return;
 
   if (save_state_ != NONE) {
     save_state_ = DELETE_AFTER_SAVE;
     return;
   }
 
   ResetState();
 }
 
+bool BackgroundLoaderOffliner::HandleTimeout(const SavePageRequest& request) {
+  // TODO(romax) device if we want to also take a snapshot on the last timeout

[Pete Williamson, 2017/02/24 22:29:03]

Nit: Device -> Decide

+  // for the background loader offliner.
+  return false;
+}
+
 void BackgroundLoaderOffliner::DidStopLoading() {
   if (!pending_request_.get()) {
     DVLOG(1) << "DidStopLoading called even though no pending request.";
     return;
   }
 
   SavePageRequest request(*pending_request_.get());
   // If there was an error navigating to page, return loading failed.
   if (page_load_state_ != SUCCESS) {
     Offliner::RequestStatus status =
@@ skipping 139 matching lines @@
       application_state ==
           base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) {
     DVLOG(1) << "App became active, canceling current offlining request";
     SavePageRequest* request = pending_request_.get();
     Cancel();
     completion_callback_.Run(*request, RequestStatus::FOREGROUND_CANCELED);
   }
 }
 
 }  // namespace offline_pages