[promises] Clean up promise utils and remove dead code

[promises] Clean up promise utils and remove dead code

BUG=v8:5343
Review-Url: https://codereview.chromium.org/2637523002
Cr-Commit-Position: refs/heads/master@{#42423}
Committed: https://chromium.googlesource.com/v8/v8/+/875165ea170feda50cec69193b50758b1d8d2de8

[gsathya, 2017-01-13 22:36:23]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 22:36:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-13 22:36:36]

Description was changed from

==========
[promises] Clean up promise utils and remove dead code

BUG=v8:5343
==========

to

==========
[promises] Clean up promise utils and remove dead code

BUG=v8:5343
==========

[gsathya, 2017-01-13 22:36:36]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2017-01-13 22:45:08]

lgtm % nits

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
File src/builtins/builtins-promise.h (right):

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.h:19: enum PromiseResolvingFunctionContextSlot {
Style: These enums should go at the top of the public: section, before even the
constructor.

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.h:21: kAlreadyVisitedSlot =
Context::MIN_CONTEXT_SLOTS,
Please add an #include for contexts.h

[commit-bot: I haz the power, 2017-01-13 23:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:22:08]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-17 16:36:36]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 16:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-17 16:36:47]

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
File src/builtins/builtins-promise.h (right):

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.h:19: enum PromiseResolvingFunctionContextSlot {
On 2017/01/13 22:45:08, adamk wrote:
> Style: These enums should go at the top of the public: section, before even
the
> constructor.

Done.

https://codereview.chromium.org/2637523002/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.h:21: kAlreadyVisitedSlot =
Context::MIN_CONTEXT_SLOTS,
On 2017/01/13 22:45:08, adamk wrote:
> Please add an #include for contexts.h

Done.

[commit-bot: I haz the power, 2017-01-17 17:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 17:07:19]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-17 17:07:58]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-01-17 17:07:59]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2637523002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2017-01-17 17:08:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 17:09:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484672878668400,
"parent_rev": "bb89869a518cb246b2c23f7e59cbbfe72e851e65", "commit_rev":
"875165ea170feda50cec69193b50758b1d8d2de8"}

[commit-bot: I haz the power, 2017-01-17 17:09:56]

Description was changed from

==========
[promises] Clean up promise utils and remove dead code

BUG=v8:5343
==========

to

==========
[promises] Clean up promise utils and remove dead code

BUG=v8:5343

Review-Url: https://codereview.chromium.org/2637523002
Cr-Commit-Position: refs/heads/master@{#42423}
Committed:
https://chromium.googlesource.com/v8/v8/+/875165ea170feda50cec69193b50758b1d8...
==========

[commit-bot: I haz the power, 2017-01-17 17:09:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/875165ea170feda50cec69193b50758b1d8...