Add an idle task to periodically sweep canceled delayed tasks

Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed tasks.
We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else wakes
the CPU up, it won't run.

BUG=680815
Review-Url: https://codereview.chromium.org/2637463002
Cr-Commit-Position: refs/heads/master@{#443877}
Committed: https://chromium.googlesource.com/chromium/src/+/fd870526d2ed5a6b3577b46aa9f01532b15bc6d5

[alex clarke (OOO till 29th), 2017-01-13 17:51:46]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 17:52:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-01-13 17:52:08]

alexclarke@chromium.org changed reviewers:
+ haraken@chromium.org, skyostil@chromium.org

[alex clarke (OOO till 29th), 2017-01-13 17:52:37]

PTAL

[commit-bot: I haz the power, 2017-01-13 17:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:56:26]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2017-01-13 18:05:07]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 18:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-01-13 18:06:39]

Description was changed from

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where
they repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled
delayed tasks.  We also add the concept of PostDelayedIdleTask to do so.

BUG=680815
==========

to

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where
they repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled
delayed tasks.  We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle period
starts. I.e. this has after wakeup semantics, i.e. unless something else wakes
the CPU up, it won't run

BUG=680815
==========

[alex clarke (OOO till 29th), 2017-01-13 18:06:55]

Description was changed from

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where
they repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled
delayed tasks.  We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle period
starts. I.e. this has after wakeup semantics, i.e. unless something else wakes
the CPU up, it won't run

BUG=680815
==========

to

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where
they repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled
delayed tasks.  We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run

BUG=680815
==========

[alex clarke (OOO till 29th), 2017-01-13 18:07:28]

Description was changed from

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where
they repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled
delayed tasks.  We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run

BUG=680815
==========

to

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed
tasks.
 We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run.

BUG=680815
==========

[alex clarke (OOO till 29th), 2017-01-13 18:07:39]

Description was changed from

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed
tasks.
 We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run.

BUG=680815
==========

to

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed
tasks.
We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run.

BUG=680815
==========

[alex clarke (OOO till 29th), 2017-01-13 18:10:07]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 18:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-01-13 18:18:31]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 18:19:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-01-13 19:00:31]

Great, lgtm with a couple of nits.

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:826:
std::priority_queue<Task> swept;
nit: How about |remaining_tasks| since the others get swept away?

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.cc
(right):

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.cc:13:
static const int kDelayedTaskSweepIntervalSeconds = 30;
nit: no need for static

[alex clarke (OOO till 29th), 2017-01-13 19:04:35]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2017-01-13 19:04:40]

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
(right):

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:826:
std::priority_queue<Task> swept;
On 2017/01/13 19:00:30, Sami wrote:
> nit: How about |remaining_tasks| since the others get swept away?

Done.

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.cc
(right):

https://codereview.chromium.org/2637463002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.cc:13:
static const int kDelayedTaskSweepIntervalSeconds = 30;
On 2017/01/13 19:00:30, Sami wrote:
> nit: no need for static

Done.

[commit-bot: I haz the power, 2017-01-13 19:05:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-01-13 19:05:16]

haraken@ Can you please stamp for the extra files? Thanks!

[commit-bot: I haz the power, 2017-01-13 21:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:31:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[haraken, 2017-01-15 23:40:24]

LGTM

[alex clarke (OOO till 29th), 2017-01-16 10:14:35]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-01-16 10:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2637463002/#ps80001
(title: "Address Sami's comments")

[commit-bot: I haz the power, 2017-01-16 10:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-01-16 11:23:39]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-01-16 11:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2637463002/#ps100001
(title: "Fix issue with tracked_objects::Location spotted by asan")

[commit-bot: I haz the power, 2017-01-16 11:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:47:04]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484565819094640,
"parent_rev": "79837964b45eb0066b6c5eb23800bedcf3dd74bf", "commit_rev":
"fd870526d2ed5a6b3577b46aa9f01532b15bc6d5"}

[commit-bot: I haz the power, 2017-01-16 12:47:32]

Description was changed from

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed
tasks.
We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run.

BUG=680815
==========

to

==========
Add an idle task to periodically sweep canceled delayed tasks

It turns out canceled delayed tasks can really pile up for some pages where they
repeatedly post dom timers with long delays and cancel them.

This patch adds an idle task which every 30s sweeps away all canceled delayed
tasks.
We also add the concept of PostDelayedIdleTask to do so.

PostDelayedIdleTask posts a task which is eligible to run after the next time an
idle 
period starts. I.e. this has after wakeup semantics, i.e. unless something else
wakes
the CPU up, it won't run.

BUG=680815

Review-Url: https://codereview.chromium.org/2637463002
Cr-Commit-Position: refs/heads/master@{#443877}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd870526d2ed5a6b3577b46aa9f0...
==========

[commit-bot: I haz the power, 2017-01-16 12:47:33]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fd870526d2ed5a6b3577b46aa9f0...