Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2637443004: DevTools: bring back old landing page in timeline/performance. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
alph
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: bring back old landing page in timeline/performance. BUG=681258 Review-Url: https://codereview.chromium.org/2637443004 Cr-Commit-Position: refs/heads/master@{#444146} Committed: https://chromium.googlesource.com/chromium/src/+/064f04c82c2f6cd3e9a77703362f9373034c248a

Patch Set 1 #

Total comments: 5

Patch Set 2 : tests passing #

Patch Set 3 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -324 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model-instrumentation.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-injected-script-eval.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-tag-1.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/layer-tree.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-time.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js View 1 chunk +0 lines, -174 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 11 chunks +154 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/module.json View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/timeline/timelineLandingPage.css View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css View 1 2 3 chunks +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 6 chunks +22 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
pfeldman
3 years, 11 months ago (2017-01-14 02:09:29 UTC) #2
alph
lgtm https://codereview.chromium.org/2637443004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/2637443004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode295 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:295: Common.UIString('Screenshots'), this._showScreenshotsSetting, Common.UIString('Show captured screenshots.')); Capture/Show screenshots. https://codereview.chromium.org/2637443004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode302 ...
3 years, 11 months ago (2017-01-14 02:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637443004/40001
3 years, 11 months ago (2017-01-17 19:45:10 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:19:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/064f04c82c2f6cd3e9a77703362f...

Powered by Google App Engine
This is Rietveld 408576698