Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2637443002: Revert of [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| (patchset #1 id:1 of https://codereview.chromium.org/2590283002/ ) Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. TBR=yosin@chromium.org Original issue's description: > [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| > > |inputType()| was added before but never used, please see bug for more > info. > > This CL doesn't have any behavior change. > > BUG=675979 > > Committed: https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f > Cr-Commit-Position: refs/heads/master@{#440193} TBR=tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=675979 Review-Url: https://codereview.chromium.org/2637443002 Cr-Commit-Position: refs/heads/master@{#443618} Committed: https://chromium.googlesource.com/chromium/src/+/d814290cfc839f8e7d02b632e33026c8878a1b3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 3 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chongz
Created Revert of [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition|
3 years, 11 months ago (2017-01-13 16:33:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637443002/1
3 years, 11 months ago (2017-01-13 16:33:46 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 18:28:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d814290cfc839f8e7d02b632e330...

Powered by Google App Engine
This is Rietveld 408576698