Change the GenerateCrashDump test to use the launcher for end-to-end testing.

Change the GenerateCrashDump test to use the launcher for end-to-end testing.

BUG=678959
Review-Url: https://codereview.chromium.org/2637433002
Cr-Commit-Position: refs/heads/master@{#443654}
Committed: https://chromium.googlesource.com/chromium/src/+/7f06b265d5c842b32d069e09329bc40fc0b1d1c7

[Sigurður Ásgeirsson, 2017-01-13 16:14:38]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:15:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-01-13 16:15:32]

Description was changed from

==========
Change the GenerateCrashDump test to use the launcher for end-to-end testing.
==========

to

==========
Change the GenerateCrashDump test to use the launcher for end-to-end testing.

BUG=678959
==========

[Sigurður Ásgeirsson, 2017-01-13 16:15:32]

siggi@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sigurður Ásgeirsson, 2017-01-13 16:17:11]

Hey Scott,

as discussed, this tests the launcher against the handler for end-to-end testing
of the machinery. I also spawn a test process to dump to minimize the odds of
flakiness. Wasn't too bad to do in the end.

Siggi

[Sigurður Ásgeirsson, 2017-01-13 16:23:58]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-01-13 18:06:01]

lgtm

https://codereview.chromium.org/2637433002/diff/20001/components/crash/conten...
File components/crash/content/app/fallback_crash_handler_win_unittest.cc
(right):

https://codereview.chromium.org/2637433002/diff/20001/components/crash/conten...
components/crash/content/app/fallback_crash_handler_win_unittest.cc:32: class
ScopedExceptionPointers {
"Scoped" seems like the wrong name for this because it's not cleaning anything
up in its destructor.

[Sigurður Ásgeirsson, 2017-01-13 18:20:03]

Thanks.

https://codereview.chromium.org/2637433002/diff/20001/components/crash/conten...
File components/crash/content/app/fallback_crash_handler_win_unittest.cc
(right):

https://codereview.chromium.org/2637433002/diff/20001/components/crash/conten...
components/crash/content/app/fallback_crash_handler_win_unittest.cc:32: class
ScopedExceptionPointers {
On 2017/01/13 18:06:01, scottmg wrote:
> "Scoped" seems like the wrong name for this because it's not cleaning anything
> up in its destructor.

Done.

[Sigurður Ásgeirsson, 2017-01-13 18:20:10]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2017-01-13 18:20:10]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2637433002/#ps40001
(title: "Address Scott's naming nit.")

[commit-bot: I haz the power, 2017-01-13 18:20:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 20:41:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484331610162810,
"parent_rev": "66b3577ead1992c749bd9af002413e6e408c5bd3", "commit_rev":
"7f06b265d5c842b32d069e09329bc40fc0b1d1c7"}

[commit-bot: I haz the power, 2017-01-13 20:42:52]

Description was changed from

==========
Change the GenerateCrashDump test to use the launcher for end-to-end testing.

BUG=678959
==========

to

==========
Change the GenerateCrashDump test to use the launcher for end-to-end testing.

BUG=678959

Review-Url: https://codereview.chromium.org/2637433002
Cr-Commit-Position: refs/heads/master@{#443654}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f06b265d5c842b32d069e09329b...
==========

[commit-bot: I haz the power, 2017-01-13 20:42:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7f06b265d5c842b32d069e09329b...