Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2637403011: Reland "[heap] Provide ObjectMarking with marking transitions" (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Provide ObjectMarking with marking transitions" BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2637403011 Cr-Commit-Position: refs/heads/master@{#42555} Committed: https://chromium.googlesource.com/v8/v8/+/0659898b3ed60214b8d25c964bbd47784060430d

Patch Set 1 #

Patch Set 2 : Fix: Remove manual marking as all spaces use black areas #

Patch Set 3 : One more fix for registering reservations #

Patch Set 4 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -194 lines) Patch
M src/heap/array-buffer-tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 8 chunks +15 lines, -22 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 14 chunks +35 lines, -58 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +71 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 34 chunks +45 lines, -69 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +12 lines, -22 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/scavenger.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (18 generated)
Hannes Payer (out of office)
lgtm
3 years, 11 months ago (2017-01-20 09:31:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637403011/60001
3 years, 11 months ago (2017-01-20 13:16:07 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 13:18:50 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/0659898b3ed60214b8d25c964bbd4778406...

Powered by Google App Engine
This is Rietveld 408576698