Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2637403009: ContextualSearchManagerTest fails because of tapBasePageToClosePanel() (Closed)

Created:
3 years, 11 months ago by amaralp
Modified:
3 years, 11 months ago
Reviewers:
Donn Denman, Theresa
CC:
chromium-reviews, donnd+watch_chromium.org, twellington+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ContextualSearchManagerTest fails because of tapBasePageToClosePanel() A regression was introduced as crrbug.com/682119 describes. The fix for it was to change the failing |tapBasePageToClosePanel()| to |closePanel()| BUG=682119 Review-Url: https://codereview.chromium.org/2637403009 Cr-Commit-Position: refs/heads/master@{#444966} Committed: https://chromium.googlesource.com/chromium/src/+/ac2bc433990822272814e5eaa3f98ebf8c5338c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
amaralp
PTAL
3 years, 11 months ago (2017-01-20 02:35:11 UTC) #6
Donn Denman
LGTM. Thanks for the fix!
3 years, 11 months ago (2017-01-20 02:38:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637403009/1
3 years, 11 months ago (2017-01-20 03:14:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 03:20:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac2bc433990822272814e5eaa3f9...

Powered by Google App Engine
This is Rietveld 408576698