cros: Change max users to be a constant

cros: Change max users to be a constant

Changing max users to be a constant instead of a dynamic config to
prepare switching from SessionStateDelegate to SessionController.
The current ash code uses the number in SystemTray::CreateItems
during initialization and does not handle dynamic change. In
SessionController case, this happens before initial SessionInfo is
sent to ash. Ash will then use the default value in SessionController
and whatever sent via SessionInfo later is ignored. This CL removes
max_users from mojom::SessionInfo and make it constant.

BUG=648964
Review-Url: https://codereview.chromium.org/2637403007
Cr-Commit-Position: refs/heads/master@{#445530}
Committed: https://chromium.googlesource.com/chromium/src/+/25ecee8b92b585ea5d0cd5d12618c32588b92299

[xiyuan, 2017-01-19 23:03:26]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 23:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:03:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-01-20 18:36:33]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 18:36:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:59:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-01-20 20:12:40]

Patchset #2 (id:20001) has been deleted

[xiyuan, 2017-01-20 20:39:10]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:23:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-01-20 21:34:38]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:34:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:13:17]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-01-23 21:31:05]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2017-01-23 22:02:59]

LGTM

[xiyuan, 2017-01-23 22:10:11]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:10:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:05:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485209411282770,
"parent_rev": "3aee9f268a3a471fa539d704e622aee1ce68f0ce", "commit_rev":
"25ecee8b92b585ea5d0cd5d12618c32588b92299"}

[commit-bot: I haz the power, 2017-01-23 23:05:37]

Description was changed from

==========
cros: Change max users to be a constant

Changing max users to be a constant instead of a dynamic config to
prepare switching from SessionStateDelegate to SessionController.
The current ash code uses the number in SystemTray::CreateItems
during initialization and does not handle dynamic change. In
SessionController case, this happens before initial SessionInfo is
sent to ash. Ash will then use the default value in SessionController
and whatever sent via SessionInfo later is ignored. This CL removes
max_users from mojom::SessionInfo and make it constant.

BUG=648964
==========

to

==========
cros: Change max users to be a constant

Changing max users to be a constant instead of a dynamic config to
prepare switching from SessionStateDelegate to SessionController.
The current ash code uses the number in SystemTray::CreateItems
during initialization and does not handle dynamic change. In
SessionController case, this happens before initial SessionInfo is
sent to ash. Ash will then use the default value in SessionController
and whatever sent via SessionInfo later is ignored. This CL removes
max_users from mojom::SessionInfo and make it constant.

BUG=648964

Review-Url: https://codereview.chromium.org/2637403007
Cr-Commit-Position: refs/heads/master@{#445530}
Committed:
https://chromium.googlesource.com/chromium/src/+/25ecee8b92b585ea5d0cd5d12618...
==========

[commit-bot: I haz the power, 2017-01-23 23:05:39]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/25ecee8b92b585ea5d0cd5d12618...

[Wez, 2017-02-08 01:03:36]

Description was changed from

==========
cros: Change max users to be a constant

Changing max users to be a constant instead of a dynamic config to
prepare switching from SessionStateDelegate to SessionController.
The current ash code uses the number in SystemTray::CreateItems
during initialization and does not handle dynamic change. In
SessionController case, this happens before initial SessionInfo is
sent to ash. Ash will then use the default value in SessionController
and whatever sent via SessionInfo later is ignored. This CL removes
max_users from mojom::SessionInfo and make it constant.

BUG=648964

Review-Url: https://codereview.chromium.org/2637403007
Cr-Commit-Position: refs/heads/master@{#445530}
Committed:
https://chromium.googlesource.com/chromium/src/+/25ecee8b92b585ea5d0cd5d12618...
==========

to

==========
cros: Change max users to be a constant

Changing max users to be a constant instead of a dynamic config to
prepare switching from SessionStateDelegate to SessionController.
The current ash code uses the number in SystemTray::CreateItems
during initialization and does not handle dynamic change. In
SessionController case, this happens before initial SessionInfo is
sent to ash. Ash will then use the default value in SessionController
and whatever sent via SessionInfo later is ignored. This CL removes
max_users from mojom::SessionInfo and make it constant.

BUG=648964

Review-Url: https://codereview.chromium.org/2637403007
Cr-Commit-Position: refs/heads/master@{#445530}
Committed:
https://chromium.googlesource.com/chromium/src/+/25ecee8b92b585ea5d0cd5d12618...
==========

[Wez, 2017-02-08 01:03:36]

wez@chromium.org changed reviewers:
+ wfh@chromium.org

[Wez, 2017-02-08 02:10:02]

Hallo wfh@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	ash/public/interfaces/session_controller.mojom
Thanks,
Wez

[xiyuan, 2017-02-08 16:03:46]

xiyuan@chromium.org changed reviewers:
+ tsepez@chromium.org

[xiyuan, 2017-02-08 16:03:47]

Oops, did not notice that owner check failed. 

tsepez@, could you do a retrospective review of
  session_controller.mojom

since you probably have more context than wfh@?

I am happy to do a follow up CL if you think anything needs to be changed.

Thanks.

[Will Harris, 2017-02-12 23:54:19]

wfh@chromium.org changed reviewers:
- wfh@chromium.org

[Will Harris, 2017-02-12 23:54:35]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[Will Harris, 2017-02-12 23:54:36]

re-opening and passing to tsepez as per comment above.

[Tom Sepez, 2017-02-13 17:54:57]

LGTM on removing a field from an existing object

[xiyuan, 2017-02-13 23:53:49]

Thanks guys.