Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2637403002: Fix header guards in //chrome (Closed)

Created:
3 years, 11 months ago by michaelpg
Modified:
3 years, 11 months ago
Reviewers:
bradnelson, Nico
CC:
chromium-reviews, rouslan+autofill_chromium.org, extensions-reviews_chromium.org, awdf+watch_chromium.org, tapted, Peter Beverloo, grt+watch_chromium.org, mlamouri+watch-notifications_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, estade+watch_chromium.org, sebsg+autofillwatch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix header guards in //chrome Mechanical change to fix incorrectly named \#include header guards. Correct names should be FILE_PATH_H_. See //tools/depot_tools/cpplint.py. BUG=none Review-Url: https://codereview.chromium.org/2637403002 Cr-Commit-Position: refs/heads/master@{#444591} Committed: https://chromium.googlesource.com/chromium/src/+/33eea59b3613f30c3df66518a23b19c8208522cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -118 lines) Patch
M chrome/browser/android/service_tab_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/warning_badge_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/stub_alert_dispatcher_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/pepper/monitor_finder_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/signature_evaluator_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_visibility_lock_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/alert_notification_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/sprite_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/split_block_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_native_widget_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/image_writer/image_writer_util_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/logging_chrome.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/benchmarking_extension.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/nacl/ppapi_test_lib/get_browser_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/nacl/ppapi_test_lib/internal_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/nacl/ppapi_test_lib/test_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/nacl/ppapi_test_lib/testable_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
michaelpg
thakis: do you (1) think it's worth committing these fixes, and (2) feel comfortable stamping ...
3 years, 11 months ago (2017-01-18 07:50:09 UTC) #2
Nico
lgtm, but just say "should be _H_" in the cl description, we don't want "_H__" ...
3 years, 11 months ago (2017-01-18 19:37:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637403002/1
3 years, 11 months ago (2017-01-18 21:14:51 UTC) #8
michaelpg
+bradnelson: PTAL for chrome/test/data/nacl
3 years, 11 months ago (2017-01-18 21:16:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/344576)
3 years, 11 months ago (2017-01-18 21:25:23 UTC) #12
bradnelson
lgtm
3 years, 11 months ago (2017-01-19 01:27:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637403002/1
3 years, 11 months ago (2017-01-19 01:28:54 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 01:35:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33eea59b3613f30c3df66518a23b...

Powered by Google App Engine
This is Rietveld 408576698