Change Painter factory functions to unique_ptr

Change Painter factory functions to unique_ptr

No behavioral changes.

BUG=678371
Review-Url: https://codereview.chromium.org/2637383003
Cr-Commit-Position: refs/heads/master@{#444783}
Committed: https://chromium.googlesource.com/chromium/src/+/477aca494328faf52dfb88b9926933e94241debe

[Evan Stade, 2017-01-18 18:59:31]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 18:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 19:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:39:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-01-19 02:45:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 02:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-19 02:45:41]

Description was changed from

==========
wip - Change painters to unique_ptr

BUG=678371
==========

to

==========
Change Painter factory functions to unique_ptr

No behavioral changes.

BUG=678371
==========

[Evan Stade, 2017-01-19 02:45:41]

estade@chromium.org changed reviewers:
+ derat@chromium.org, msw@chromium.org

[Evan Stade, 2017-01-19 02:46:40]

+derat for ash/
+msw for the rest

[Daniel Erat, 2017-01-19 02:57:48]

lgtm for ash/

[commit-bot: I haz the power, 2017-01-19 03:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:38:23]

Dry run: This issue passed the CQ dry run.

[msw, 2017-01-19 09:46:53]

nice cleanup; lgtm with nits

https://codereview.chromium.org/2637383003/diff/20001/ash/common/wm/window_cy...
File ash/common/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2637383003/diff/20001/ash/common/wm/window_cy...
ash/common/wm/window_cycle_list.cc:17: #include "base/memory/ptr_util.h"
nit: this include may not be needed anymore

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_ui.cc:690: std::unique_ptr<views::Painter>
painter = nullptr;
nit: |= nullptr| no longer needed.

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_ui.cc:697:
gtk_border->SetPainter(paintstate[i].focus, paintstate[i].state,
optional nit/q: i wonder if we can just skip SetPainter for null painters and
simplify this block:
  for (unsigned i = 0; i < arraysize(paintstate); i++) {
    if (border->PaintsButtonState(paintstate[i].focus, paintstate[i].state)) {
      std::string idr = is_blue ? paintstate[i].idr_blue : paintstate[i].idr;
      gtk_border->SetPainter(paintstate[i].focus, paintstate[i].state,
                             base::MakeUnique<GtkButtonPainter>(idr));
    }
  }

[Evan Stade, 2017-01-19 16:26:29]

https://codereview.chromium.org/2637383003/diff/20001/ash/common/wm/window_cy...
File ash/common/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2637383003/diff/20001/ash/common/wm/window_cy...
ash/common/wm/window_cycle_list.cc:17: #include "base/memory/ptr_util.h"
On 2017/01/19 09:46:53, msw (out 1-19) wrote:
> nit: this include may not be needed anymore

Done.

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_ui.cc:690: std::unique_ptr<views::Painter>
painter = nullptr;
On 2017/01/19 09:46:53, msw (out 1-19) wrote:
> nit: |= nullptr| no longer needed.

Done.

https://codereview.chromium.org/2637383003/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_ui.cc:697:
gtk_border->SetPainter(paintstate[i].focus, paintstate[i].state,
On 2017/01/19 09:46:53, msw (out 1-19) wrote:
> optional nit/q: i wonder if we can just skip SetPainter for null painters and
> simplify this block:
>   for (unsigned i = 0; i < arraysize(paintstate); i++) {
>     if (border->PaintsButtonState(paintstate[i].focus, paintstate[i].state)) {
>       std::string idr = is_blue ? paintstate[i].idr_blue : paintstate[i].idr;
>       gtk_border->SetPainter(paintstate[i].focus, paintstate[i].state,
>                              base::MakeUnique<GtkButtonPainter>(idr));
>     }
>   }

I think you're right, done.

[Evan Stade, 2017-01-19 16:26:32]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-19 16:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2637383003/#ps40001
(title: "msw review")

[commit-bot: I haz the power, 2017-01-19 16:26:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:59:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484843192730300,
"parent_rev": "072742fba50cd351ef4b7d7b4b73f348b157ddef", "commit_rev":
"477aca494328faf52dfb88b9926933e94241debe"}

[commit-bot: I haz the power, 2017-01-19 18:00:06]

Description was changed from

==========
Change Painter factory functions to unique_ptr

No behavioral changes.

BUG=678371
==========

to

==========
Change Painter factory functions to unique_ptr

No behavioral changes.

BUG=678371

Review-Url: https://codereview.chromium.org/2637383003
Cr-Commit-Position: refs/heads/master@{#444783}
Committed:
https://chromium.googlesource.com/chromium/src/+/477aca494328faf52dfb88b99269...
==========

[commit-bot: I haz the power, 2017-01-19 18:00:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/477aca494328faf52dfb88b99269...