Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2637353002: Updated settings icon in Timeline panel (Closed)

Created:
3 years, 11 months ago by chowse
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated settings icon in Timeline panel BUG= Review-Url: https://codereview.chromium.org/2637353002 Cr-Commit-Position: refs/heads/master@{#444549} Committed: https://chromium.googlesource.com/chromium/src/+/28a28f0874dce5c40e04b91bb224a242fee98830

Patch Set 1 #

Patch Set 2 : Removed extra SVG changes made by Inkscape #

Messages

Total messages: 15 (5 generated)
chowse
On 2017/01/18 02:15:38, chowse wrote: > mailto:chowse@chromium.org changed reviewers: > + mailto:pfeldman@chromium.org Here's the new ...
3 years, 11 months ago (2017-01-18 02:17:38 UTC) #3
pfeldman
Somehow your editor changed too many parts of this file.
3 years, 11 months ago (2017-01-18 02:21:20 UTC) #4
chowse
On 2017/01/18 02:21:20, pfeldman wrote: > Somehow your editor changed too many parts of this ...
3 years, 11 months ago (2017-01-18 07:00:32 UTC) #5
chowse
On 2017/01/18 07:00:32, chowse wrote: > On 2017/01/18 02:21:20, pfeldman wrote: > > Somehow your ...
3 years, 11 months ago (2017-01-18 22:04:14 UTC) #6
pfeldman
lgtm
3 years, 11 months ago (2017-01-18 22:11:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637353002/20001
3 years, 11 months ago (2017-01-18 22:12:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/28a28f0874dce5c40e04b91bb224a242fee98830
3 years, 11 months ago (2017-01-18 23:52:12 UTC) #12
einbinder
On 2017/01/18 at 23:52:12, commit-bot wrote: > Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/28a28f0874dce5c40e04b91bb224a242fee98830 Running the ...
3 years, 11 months ago (2017-01-19 07:57:17 UTC) #13
pfeldman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2644083004/ by pfeldman@chromium.org. ...
3 years, 11 months ago (2017-01-19 16:07:49 UTC) #14
pfeldman
3 years, 11 months ago (2017-01-19 16:08:32 UTC) #15
Message was sent while issue was closed.
we need to revert it and merge the revert into the branch now.

Powered by Google App Engine
This is Rietveld 408576698