third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: #2 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp » ('j') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

index bc8fa2275141d706aff8e38a7a2264aebd055e21..de176f3baefd53a41ce087a7e7caaed76cedbd26 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

@@ -18,7 +18,8 @@ class BluetoothRemoteGATTUtils final {

enum ExceptionType {

ortuno 2017/01/20 04:30:53 Out of curiosity, why is this not an enum class?

dougt 2017/01/23 21:40:37 No reason, really. Follow up?

ortuno 2017/01/23 22:20:42 SGTM

kGATTServerDisconnected,

kGATTServerNotConnected,

- kInvalidCharacteristic

+ kInvalidCharacteristic,

+ kInvalidDescriptor

};

static DOMException* CreateDOMException(ExceptionType);