 Chromium Code Reviews
 Chromium Code Reviews Issue 2637343002:
  Implement WebBluetooth descriptor.readValue()  (Closed)
    
  
    Issue 2637343002:
  Implement WebBluetooth descriptor.readValue()  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef BluetoothRemoteGATTUtils_h | 5 #ifndef BluetoothRemoteGATTUtils_h | 
| 6 #define BluetoothRemoteGATTUtils_h | 6 #define BluetoothRemoteGATTUtils_h | 
| 7 | 7 | 
| 8 #include "core/dom/DOMDataView.h" | 8 #include "core/dom/DOMDataView.h" | 
| 9 #include "core/dom/DOMException.h" | 9 #include "core/dom/DOMException.h" | 
| 10 #include "wtf/Vector.h" | 10 #include "wtf/Vector.h" | 
| 11 | 11 | 
| 12 namespace blink { | 12 namespace blink { | 
| 13 | 13 | 
| 14 class BluetoothRemoteGATTUtils final { | 14 class BluetoothRemoteGATTUtils final { | 
| 15 public: | 15 public: | 
| 16 static DOMDataView* ConvertWTFVectorToDataView(const WTF::Vector<uint8_t>&); | 16 static DOMDataView* ConvertWTFVectorToDataView(const WTF::Vector<uint8_t>&); | 
| 17 | 17 | 
| 18 enum ExceptionType { | 18 enum ExceptionType { | 
| 
ortuno
2017/01/20 04:30:53
Out of curiosity, why is this not an enum class?
 
dougt
2017/01/23 21:40:37
No reason, really. Follow up?
 
ortuno
2017/01/23 22:20:42
SGTM
 | |
| 19 kGATTServerDisconnected, | 19 kGATTServerDisconnected, | 
| 20 kGATTServerNotConnected, | 20 kGATTServerNotConnected, | 
| 21 kInvalidCharacteristic | 21 kInvalidCharacteristic, | 
| 22 kInvalidDescriptor | |
| 22 }; | 23 }; | 
| 23 | 24 | 
| 24 static DOMException* CreateDOMException(ExceptionType); | 25 static DOMException* CreateDOMException(ExceptionType); | 
| 25 }; | 26 }; | 
| 26 | 27 | 
| 27 } // namespace blink | 28 } // namespace blink | 
| 28 | 29 | 
| 29 #endif // BluetoothRemoteGATTUtils_h | 30 #endif // BluetoothRemoteGATTUtils_h | 
| OLD | NEW |